Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical glitch when repeatedly clicking on a rippled element. #18

Closed
waylaidwanderer opened this issue Sep 17, 2014 · 11 comments
Closed

Comments

@waylaidwanderer
Copy link

I found this on the navbar but I assume it'd be the same for other ripply elements too. If you spam-click a link, the ripple overlay sometimes doesn't get removed so the element gets darker and darker. If you're not sure what I'm talking about, try it on one of the navbars on your demo page: http://fezvrasta.github.io/bootstrap-material-design/

@FezVrasta
Copy link
Contributor

I'm aware of this problem but I can't find what is the error...

@waylaidwanderer
Copy link
Author

I found the source of the problem. document.dispatchEvent seems to be unreliable. I've tested a fix that seems to work and I'll make a pull request once you've looked at #21.

@FezVrasta
Copy link
Contributor

Still open to PRs for this bug.

@roeku
Copy link

roeku commented Sep 26, 2014

Well i too noticed this when i first came in contact with this git. I didn't make an issue of it because when you click on a button it's supposed to perform an action which would negate a user spamclicking a button. Don't get me wrong it would be better if it didn't bug out but looking at it from a UI perspective i don't consider it an issue.

@FezVrasta
Copy link
Contributor

It can cause problems if you apply the ripple effect to something that is not a link (an image, a dropdown toggle etc)

I'd very like to fix this problem :/

@shak18
Copy link

shak18 commented Sep 27, 2014

this could help you fix the issue there are 4 great approaches to ripple and doesnt seem to have that bug

http://codepen.io/madshaakansson/pen/ykode

http://codepen.io/KrisOlszewski/pen/Dnktj

http://codepen.io/Craigtut/pen/dIfzv

http://codepen.io/idiotWu/pen/nefhC

hope it can help cause youre making a great job with this :)

@FezVrasta
Copy link
Contributor

All of them have a trouble, when you hold the mouse down the ripple does not stay active. And this is the difficult part of my script which makes it different and(possibly) better than others

@aarohmankad
Copy link

Has this since been fixed? I can't seem to replicate the issue.

@ezpuzz
Copy link

ezpuzz commented Sep 28, 2014

Definitely gets darker after repeated clicks for me in FF33, I like that last example shak18 posted.

@waylaidwanderer
Copy link
Author

I've submitted a pull request that should fix this problem.

@waylaidwanderer
Copy link
Author

I've updated the pull request to allow multiple ripples to animate while still removing old ripples correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants