Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic docs publishing #218

Closed
RyanZim opened this issue Nov 28, 2016 · 26 comments
Closed

Automatic docs publishing #218

RyanZim opened this issue Nov 28, 2016 · 26 comments
Labels
enhancement New feature or request PR Pending

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Nov 28, 2016

@mde When you published the latest version, what happened with the automatic documentation push to gh-pages? I don't see the branch.

@mde
Copy link
Owner

mde commented Nov 29, 2016

I didn't have git-directory-deploy installed (and didn't notice it was a requirement). I will be doing another release soon, so it should update correctly then.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

@mde It is listed in the devDeps, just run npm i and it should install automatically.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

BTW, good catch on that root option.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

@mde If you'd like, I can just run the doc docPublish task to update them now.

@mde
Copy link
Owner

mde commented Nov 29, 2016

Yes, I know how to install dependencies. :) I just hadn't noticed it had been added. I'll run the doc task now.

@mde
Copy link
Owner

mde commented Nov 29, 2016

Can you verify the gh-pages was correctly updated?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

@mde Ain't seeing it; let me try.

BTW, is gh-pages listed when running git branch?

@mde
Copy link
Owner

mde commented Nov 29, 2016

No, it's not.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

I ran jake docPublish manually, and it worked fine: http://mde.github.io/ejs/.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

What was the output when you ran jake publish?

@mde
Copy link
Owner

mde commented Nov 29, 2016

It complained about git-directory-deploy not being installed.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

Sorry, my comment above was incorrect, you need to run jake docPublish to update them on the server. jake doc just updates the local copy. docPublish runs doc first, that pushes to gh-pages.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

Anyhow, it's working now; let me know if it chokes on the next release. If you're not sure if it worked; take a peek at https://github.com/mde/ejs/tree/gh-pages, and see when the latest commit was.


Do you want to hook up the gh-pages to api.ejs.co sometime? If we do that, we should link from ejs.co to there, and include a link to ejs.co from the JSDocs.

@mde
Copy link
Owner

mde commented Nov 29, 2016

Ah, I didn't look closely at the Jakefile to see what those tasks do. :)

Sure, let's hook up the API docs. How does GH Pages do domain aliasing?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

Set api.ejs.co to CNAME mde.github.io.

I'll need to modify the Jakefile to insert a CNAME file just before publishing; PR coming.

The subdomain should then connect after the next release.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

@mde BTW, do not set a wildcard record (*.ejs.co) pointing to gh-pages; that will allow anyone to publish a site on another subdomain.

@mde
Copy link
Owner

mde commented Nov 29, 2016

I only ever set a wildcard to the same as the www server, no worries. :)

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

@mde That's my point; never set a wildcard pointing to any of GitHub's servers.

Danger: Do not use wildcard DNS records (e.g. *.example.com) with GitHub Pages! A wildcard DNS record will allow anyone to host a GitHub Pages site at one of your subdomains.

https://help.github.com/articles/setting-up-a-custom-subdomain/

@mde
Copy link
Owner

mde commented Nov 29, 2016

Yes, I was saying I'd never do that -- I would only ever make wildcard entry that points to the same IP address as the existing www or main web server.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Nov 29, 2016

Here's your PR, merge at will: #219.

@RyanZim RyanZim added PR Pending enhancement New feature or request labels Dec 2, 2016
@RyanZim
Copy link
Collaborator Author

RyanZim commented Feb 20, 2017

@mde Can you set the CNAME record for api.ejs.co?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Mar 25, 2017

@mde ping?

@mde
Copy link
Owner

mde commented May 7, 2017

I've set it up. Not sure how long it will take to propagate.

@mde
Copy link
Owner

mde commented May 7, 2017

screen shot 2017-05-07 at 11 55 55 am

@RyanZim
Copy link
Collaborator Author

RyanZim commented May 8, 2017

It works! http://api.ejs.co/

@RyanZim RyanZim closed this as completed May 8, 2017
@mde
Copy link
Owner

mde commented May 8, 2017

Sweeeeeeeeet! Sorry this took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR Pending
Projects
None yet
Development

No branches or pull requests

2 participants