This repository has been archived by the owner on Jan 26, 2020. It is now read-only.
TimezoneJS should be a little bit more robust when test frameworks wrap the Date constructor. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Date constructor (poorly) Specifically, SinonJS overwrites the Date constructor with a function that produces date objects whose constructor property is the original Date constructor, while Date currently refers to the Sinon wrapper. That hullabaloo makes a.constructor !== Date end up true when it should be false.
longlho
added a commit
that referenced
this pull request
May 6, 2013
TimezoneJS should be a little bit more robust when test frameworks wrap the Date constructor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer failing to detect dates when test frameworks overwrite the Date constructor (poorly)
Specifically, SinonJS overwrites the Date constructor with a function that produces date objects
whose constructor property is the original Date constructor, while Date currently refers to the Sinon wrapper.
That hullabaloo makes a.constructor !== Date end up true when it should be false.