Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add external sources configuration #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdeicas
Copy link
Owner

@mdeicas mdeicas commented Aug 4, 2022

No description provided.

@mdeicas mdeicas changed the title add external sources configuration [WIP] add external sources configuration Aug 4, 2022
@mdeicas mdeicas closed this Aug 4, 2022
@mdeicas mdeicas reopened this Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    13.9ms ± 2%    14.8ms ±28%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.61ms ± 8%    1.65ms ± 3%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.94ms ± 1%    4.06ms ± 1%  +3.10%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.28ms ± 1%    1.31ms ± 3%  +2.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         891µs ± 0%     928µs ± 3%  +4.16%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.05ms ± 1%    1.11ms ± 2%  +5.62%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.52ms ± 0%    1.62ms ± 2%  +6.22%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      17.5ms ± 0%    17.3ms ± 2%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.48ms ± 2%    1.53ms ± 3%  +3.39%  (p=0.016 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.76µs ± 1%    2.75µs ± 4%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.63ms ± 1%    1.69ms ± 3%  +3.51%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    838µs ± 0%     888µs ± 3%  +5.91%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     945kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%    ~     (p=0.341 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      302kB ± 0%     301kB ± 0%  -0.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%    ~     (p=0.841 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%  -0.06%  (p=0.032 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%    ~     (p=1.000 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%    ~     (p=1.000 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%    ~     (p=0.365 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%    ~     (p=0.643 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%    ~     (p=0.333 n=5+4)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.12k ± 0%     8.12k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%    ~     (p=0.968 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%    ~     (p=0.556 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%    ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%    ~     (all equal)

Copy link

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial comments - love the interface work!

cmd/syft/cli/options/packages.go Outdated Show resolved Hide resolved
syft/pkg/cataloger/cataloger.go Show resolved Hide resolved
syft/pkg/cataloger/cataloger.go Show resolved Hide resolved
@mdeicas mdeicas force-pushed the external-sources-config branch 2 times, most recently from a3cec9e to 1cc70ce Compare August 11, 2022 22:46
Signed-off-by: Marco Deicas <mdeicas@google.com>
Copy link

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants