Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iPad Pro support #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add iPad Pro support #42

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5112b4e
iPad Pro support added
parthavmiyani Mar 26, 2022
8930df1
added new version support for safari
parthavmiyani Mar 26, 2022
f0ffc2a
increased fallback redirection time for slow loading apps
parthavmiyani Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/public/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function deepLink(options) {
document.location = url;
setTimeout(function () {
document.location = fallback;
}, 250);
}, 2500);
Copy link
Owner

@mderazon mderazon Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to increas it ?
The page is basically empty with hardly any code / html in it so it should be loaded instantly
2.5 sec is noticable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am facing the same issue as #27.
in my case, app usually takes approx 1.5 sec to load.
When I open the app, it immediately redirects me to the app store. so I add some time to the app gets load perfectly

}

function launchIframeApproach(url, fallback) {
Expand All @@ -82,7 +82,7 @@ function deepLink(options) {
// chrome and safari on ios >= 9 don't allow the iframe approach
if (
ua.match(/CriOS/) ||
(ua.match(/Safari/) && ua.match(/Version\/(9|10|11|12)/))
(ua.match(/Safari/) && ua.match(/Version\/(9|10|11|12|13|14|15)/))
) {
launchWekitApproach(urls.deepLink, urls.iosStoreLink || urls.fallback);
} else {
Expand Down