Complete rewrite of character decoding (not active yet) (#38) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a code generator to create fast decoder code - Use substring instead of substr (which MDN advises against) - Optional error handler in case the application needs to throw an error - Generally compliant with HTML 4/5 standard
|
Hello @dan1wang. This is amazing work! I'm going to review this soon. |
dan1wang
commented
Jun 3, 2019
| } else {` + /* https://infra.spec.whatwg.org/#c0-control */ ` | ||
| if (((num > ${0xFDD0-1}) && (num < ${0xFDEF+1})) || ([${NON_CHARACTER.join(',')}].indexOf(num) >= 0)) { | ||
| parseError("${ERRORS.NON_CHARACTER.MSG}",${ERRORS.NON_CHARACTER.CODE}); | ||
| } else if ((num == ${0x0D}) || (num < ${0x001F+1})) { |
There was a problem hiding this comment.
Mistake here. C0 control characters other than \x09 (tab), \x0A (lf), \x0C (ff), and \x20 (space) are invalid. Should be
} else if ( (num < ${0x20}) && (num != ${0x09}) && (num != ${0x0A}) && (num != ${0x0C}) ) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substringinstead ofsubstr(which MDN advises against)The new code is not attached to the main classes yet (so someone else can do benchmark test first).
The decoder has a strict mode (off by default). In strict mode, the decoder would reject all entities without trailing semicolon as well as
",<,>, and&HTML4 decoder will accept all HTML4 named entities plus
'which is part of XHTML 1.0 and XML but not part of HTML 4.Benchmark result on Windows 10 as followed: