Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for "Always" registries #24

Closed
wants to merge 4 commits into from
Closed

Conversation

ShaunLawrie
Copy link

The UI for this thing is awesome. I have had an idea for integrating registries which are valid for when there are no results in PSRun for example searching for an app which isn't installed could suggest looking for it in winget/scoop/choco/brew/apt.

There are potentially other situations but my main use-case would be winget.

I've hacked together this proof of concept to see if you think it could work. It's a bit sketchy 😆 I just copied your file registry and hacked it until it worked. I'm also not sure if "Always" is the right term, maybe "Search" registries.

GlobalStore at the moment is hard coded to the built-in registries, so I've just added it to the list to get it to work.

psrun.mp4

@mdgrs-mei
Copy link
Owner

Wow, thank you for the experiment! Let me look into your code.

@mdgrs-mei
Copy link
Owner

I have actually been thinking about a similar idea. I think it's basically the same as the "Search the web in Firefox" entry in PowerToys Run. However, I personally feel that this suggestion entry is not so intuitive.

I would prefer typing "winget" to pick "Winget (PSRun)" entry for example when I want to install something, and then inside the Winget item I would want to filter the packages. So typing what I want to do is clearer to me. Does it make sense? Probably I would like to keep the simple filtering behavior until we find some other use cases. Your Winget registry is pretty useful though.

@ShaunLawrie
Copy link
Author

I personally feel that this suggestion entry is not so intuitive.

Same, I tried it out this way because it was easy to get it running 😆

when I want to install something, and then inside the Winget item I would want to filter the packages. So typing what I want to do is clearer to me. Does it make sense?

Yep. It would be cool to keep the realtime search feel but it would require some debouncing to make sure it's not spamming a slow resource lookup with every keystroke. Otherwise a "search on enter" experience would be fine to keep it simpler.

I haven't looked properly yet but I suspect that with a slower async preview it's actually firing off every time the item changes even when you scroll past the items which could benefit from debouncing too.

Thanks for the module I learned a lot just digging around.

@mdgrs-mei
Copy link
Owner

mdgrs-mei commented Mar 28, 2024

I'm really happy to hear that you like the module 😄!

As for the realtime search, even if we support it in the PowerShellRun's search bar, what gives us the search functionality here is the winget module. We can't get both winget filter and PowerShellRun's filter at the same time. So "search on enter" might be better in this case.

Just like the example #25, you can ask for an input first and then open the TUI. It doesn't look cool though.

@mdgrs-mei
Copy link
Owner

@ShaunLawrie Are you still interested in continuing this PR? It might not be the case if the main point was the 'Always' part. In either case I might create Winget Utility entry combining this Install feature and my Upgrade example in the future.

@ShaunLawrie
Copy link
Author

ShaunLawrie commented Mar 30, 2024 via email

@mdgrs-mei
Copy link
Owner

Ok no problem! Thank you again for the PR. It was inspiring. Good luck for the talk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants