Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement search filter #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: implement search filter #108

wants to merge 2 commits into from

Conversation

NanoNish
Copy link
Contributor

No description provided.

@NanoNish
feat: add search fields & remove institute filter
23d7483
@NanoNish
refactor: change query updates and search events
1d65ddd 
- query changed to state prop updated from UpdateQuery event
- replaced filter field updates with search event
- handle zero search results
@NanoNish
Copy link
Contributor Author

Two things that are still to be added but I have a doubt on them are:

  • TextInput has a validator prop but when does it actually trigger?
  • should we convert filter list to radio buttons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aman-singh7 aman-singh7 Awaiting requested review from aman-singh7

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NanoNish