docker with docker-mods enabled #1645
Comments
|
Yeah just updated sma-mod to support the new s6v3 that the linuxserver is migrating all their packages to but it looks like sonarr:latest is the only one that hasn't crossed over yet, for now I would use either the https://github.com/mdhiggins/sma-mod/pkgs/container/sma-mod/65189830 |
|
new pull this morning, new error: Brought to you by linuxserver.ioTo support the app dev(s) visit: To support LSIO projects visit:
|
|
trying a DL, errors: seems requirements not being followed |
|
copy and paste the script into docker, seems to complete with no errors: ffmpeg and ffprobe installed, anything else? |
|
Yeah the SMA setup scripts aren't running because of the s6 change. Rolling back to the old version should have fixed things but it looks like the mod version that's being applied isn't using the old version still. I'll probably have to make an old s6v2 tag to bridge the gap until they update the last Sonarr container |
|
well, until there's a good docker, I'll play with what I have. [Permissions] [Metadata] [Video] [HDR] [Audio] [Audio.Sorting] [Universal Audio] [Audio.ChannelFilters] [Subtitle] [Subtitle.Sorting] [Subtitle.CleanIt] [Subtitle.FFSubsync] [Subtitle.Subliminal] [Subtitle.Subliminal.Auth] [Sonarr] [Radarr] [Sickbeard] [Sickrage] [SABNZBD] [Deluge] [qBittorrent] [uTorrent] [Plex] I think the above should pass to ffmpeg to copy video, down mix from 6 channels to 2, don't think that is occurring: video is good, audio not |
|
Alright the new s6v2 tag has been published
You can also just not specify any subtitle codecs https://github.com/mdhiggins/sma-mod/pkgs/container/sma-mod/66445676?tag=s6v2 |
|
changed ignore-embedded-subs = True, no change 33 subtitles found |
|
with empty values for subtitles, errors: with null for values, errors: |
|
You're getting an error for a completely different option. Read the error. Can't have a null value for a Boolean, needs to be true or false include-original-language |
|
Show the logs for ignore embedded subs. Just cause they are found in the source file doesn't mean they are necessarily copied to the output file |
|
$docker logs sabnzbd |
|
Input #0, matroska,webm, from '/mnt/storage/medialibrary/tv/The.Lincoln.Lawyer/Season 1/The.Lincoln.Lawyer.S01E06.Bent.1080p.NF.WEB-DL.DDP5.1.Atmos.HEVC-SKiZOiD.mkv': That is the the output AFTER postprocessing |
|
You're still applying the wrong mod tag Your logs show mdhiggins/sma-mod:latest You need to do mdhiggins/sma-mod:s6v2 |
|
|
|
Take out LATEST that's the wrong tag! You can't have more than one tag and docker will only apply the first one |
|
ok, bone headed on my part, fixed, DOCKER_MODS: mdhiggins/sma-mod:s6v2 I can pip install -r /app/sabnzbd/tests/requirements.txt, but there are many more errors |
|
All pip requirements are and always have been installed in a virtual environment. You need to use /usr/local/sma/venv/bin/python3 to execute any Python scripts not just the base Python installation in the container |
|
well, I don't know what to say, other than I've tried this program on two different computers, and the errors are the same, indicating that the requirements.txt is not being installed, this occurs on both computers. root@c887f2842b8f:/usr/local/sma/venv/bin# pip3 install tmdbsimple root@c887f2842b8f:/usr/local/sma/venv/bin# /usr/local/sma/manual.py root@c887f2842b8f:/usr/local/sma/venv/bin# pip3 install mutagen root@c887f2842b8f:/usr/local/sma/venv/bin# /usr/local/sma/manual.py |
|
manual process log: 2023-01-28 13:19:39 - MANUAL - INFO - Manual processor started. During handling of the above exception, another exception occurred: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): @debiancam:/mnt/storage/medialibrary/tv$ ls -all |
|
There continues to be a misunderstanding and I don't mean to be condescending but I think you are missing some core concepts about how linux command lines function and determine which executable is chosen when entering a command that is making this harder than it needs to be, link below might provide some insight into the PATH and how execs are chosen; you may also want to read up on how which execs are associated with which file extensions https://unix.stackexchange.com/a/3837 From your sample above, you open bash on the docker container on line one which is fine Line 2 you try to change into the virtual environment python3 executable like its a directory which is not possible and probably threw an error, running that same command inside the radarr container for me shows Line 3 you install the requirements using pip3 but you do this on the system level python installation. The virtual environment already has the requirements anyone so this step is unnecessary. When you navigate to a directory with an executable in it, in this case See the difference? manual.py actually prints this path for you at the start of its execution to hopefully inform the user which python3 executable is being used which is how I know you're still using the wrong one; from your logs: The final line of your sample is Specify the **./**python3 while inside the directory OR just use the full absolute paths which can be done from any directory Now, moving on your your most recent logs It looks like despite these issues you managed to get enough installed on the main system python3 environment to avoid exceptions due to missing requirements. Manual.py is able to run through its process and you're getting an FFMPEG error at the very end of the file when trying to tag your MKV file. Your first exception But you don't need to keep installing requirements. This is a docker container with millions of downloads that comes with all the requirements preinstalled and aside from the recent hiccup related to the parent container switching to s6v3 its well tested and has what you need included |
|
Also as another aside It appears you are going from an MKV source to an MKV output which is fine. By default the script will not actually process/convert these files if they are already in the same extension but instead just tag them and move on You may wish to turn on |
|
well, I'm going to confuse you even more. |
|
from the computer that has not pip show, pip install run you said: root@c887f2842b8f:/config# cd /usr/local/sma/venv/bin |
|
I can only go by the exact information you post but it appears the logs are mixed together or tweaked in some way since some of the responses and logging are inconsistent. I tried to be as detailed as I can be in the above post. With regards to
This is because you included For the next comment - even if you're installing the requirements you're still installing them on the main python installation at the system level not the virtual environment, you would need to use pip3 inside the venv directory to act only on the virtual environment. Now, the guessit import failure does suggest that you are missing the requirements and the command you linked appears correct but there's been so many modifications to the container its hard to say for sure why this isn't working. There are docker-compose setups for multiple different images and a mix and match of all kinds of logs and output that don't logically follow. The installation of the pip requirements is handled by the startup script (90-sma-config for s6v2, init-sma-config/run for s6v3), but this same script is also what creates the virtual environment so its odd that you would have one and not the other unless there was a failure during that initial startup script somewhere in between those two steps I think at this point I just need a fresh, direct copy paste full set of logs including the following:
All of this stuff needs to be direct copy and paste from the source and not pieced together, no excerpts of segments, and not merged from multiple attempts as the confounding information from doing those things makes it very difficult to determine what's going on with your setup. I need all 3 of these things. With that information, since its docker, I can recreate your exact setup and reproduce the problem and fix the image if its truly an image/mod problem or maybe tell you where you're doing wrong. Assume all information is relevant when copying that information, don't remove anything |
|
So, I dug through your original post and recreated your original container. I realize however that I was operating under incorrect information, I think early on I had mixed up your issue with another recent issue and thought you were applying sma-mod to Sonarr. My early posts all refer to Sonarr. I realized when trying to recreate your container that you are actually using SABNZBD I went and checked Linuxserver's github and it looks like SABNZBD is actually on s6v3 not v2 like Sonarr. That means my initial assumption that you needed to roll back to an older version was inaccurate, I believe only Sonarr remains on that version. I used the following test configuration Running that on the first launch of the container with no modifications, I'm able to open it up and run manual.py without issue So I think the initial problem was that you were using the wrong environment, but then by having you switch to the s6v2 tag I inadvertently broke your virtual environment due to the mismatch because I was thinking you were on Sonarr no SABNZBD which then when you started using the correct path didn't work Try and mirror the options above and see what you get, you may be able to disregard the last post since I think that's the issue |
|
well, different os, different computer, same docker set up, its all in the zip If you want me to enter commands, please be specific. |
Since we're mostly dealing with Python exceptions and input errors I think the OS being the same inside the container is more than enough to consider it the same, not worried about kernel/driver level variances at this point lol Skimmed through the zip and I'm thinking the solution offered in #1645 (comment) should close this out and solve the problem |
|
/usr/local/sma/venv/bin/python3 /usr/local/sma/manual.py name: compose on the host: in the docker: |
|
Good, so your virtual environment is working correctly as evidenced by manual.py launching without import errors Now its kind of looking like you might have then moved SABPostProcess.py to its own directory inside your /config/scripts folder without its dependencies and tried to run it as a .py file without specifying the virtual python environment again essentially circumventing the virtual environment all over again after all that. Moving SABPostProcess.py also breaks it since it depends on many of those other python files in the SMA directory which is why you're getting all those new import errors So, first I would change your SAB scripts directory to Then, setup your categories and choose
This is because as I tried to explain earlier, .py files will execute with whatever the operating system default PATH setting is which in this case is For your info, this is what that file looks like #!/usr/bin/env bash
# env check
if [[ -z "${SMA_PATH}" ]]; then
export SMA_PATH="/usr/local/sma"
fi
$SMA_PATH/venv/bin/python3 $SMA_PATH/SABPostProcess.py "$@"You'll also want to make sure that your category name, in this case "sonarr" matches whatever category name you have in autoProcess.ini under the SABNZBD section
If for some reason you don't want to use /usr/local/sma as your scripts directory (like you have other scripts etc) you can copy SABPostProcess.sh wherever you want, it uses absolute paths so it does not need to remain in the /usr/local/sma directory |
|
Without your patience, understanding and hand holding, my problems are solved. |
|
Glad it's all working 👍 |
Linux gettech 5.10.0-20-amd64 #1 SMP Debian 5.10.158-2 (2022-12-13) x86_64 GNU/Linux
$docker logs sabnzbd
[custom-init] No custom services found, skipping...
[mod-init] Attempting to run Docker Modification Logic
[mod-init] Applying mdhiggins/sma-mod:latest files to container
tar: can't open '/modtarball.tar.xz': No such file or directory
cp: cannot stat '/tmp/mod/*': No such file or directory
[mod-init] mdhiggins/sma-mod:latest applied to container
[migrations] started
[migrations] no migrations found
$docker exec -it sabnzbd /bin/bash
root@gettech:/# ffmpeg
bash: ffmpeg: command not found
root@gettech:/# ffprobe
bash: ffprobe: command not found
The text was updated successfully, but these errors were encountered: