Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to move mp4 file when all conversion and tagging is complete #4

Closed
wants to merge 1 commit into from
Closed

Conversation

mstrelan
Copy link
Contributor

Another workaround for iTunes. Thank you so much for adding the "output directory" function, however it's not quite right for use with iTunes. The issue is that iTunes will detect the file before you've finished tagging it and you'll end up with an untagged file in iTunes. One way to get around this is to move the file when it's finished processing. With this patch I can set the output directory to I:\Temp and then the move directory / final destination to I:\Automatically Add to iTunes. Does this seem reasonable?

@mdhiggins
Copy link
Owner

Fixed as of 2.3.5

Used a solution similar to yours but without the extra option. Basically took the functionality to move the file, which was built into the mkvtomp4 class, and moved it to the postConversion.py script so that it would occur after the tagging is complete. The incomplete file is now processed in the same directory as the source file. This removed the redundancy that would have existed if we created a second option.

@mdhiggins mdhiggins closed this Feb 18, 2013
@mstrelan
Copy link
Contributor Author

Fair call. I will however explain my reasoning for having both options.

I have Sickbeard setup to downloads tv shows to D:\TV Shows and I have setup iTunes to use a separate drive (I:). Moving/renaming a file on a single drive takes only a couple of seconds or less, but moving a file between drives can take far longer, particularly if it's a 1080p Game of Thrones episode which is 4.5GB. So sickbeard_mp4_automator will create the mp4 on D drive and then copy it to I drive, however it is much faster to create it on I drive immediately then move it to the right folder.

I do acknowledge that not many people would have the same configuration so I'm happy to put up with the extra time spent moving between drives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants