Handle "N/A" as valid value of the XOFFBATT field. Fixes #2. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your suggestion seems reasonable to me, though I'd be curious to know exactly which fields apcupsd can return "N/A" for. |
|
I'll merge this as-is unless you'd like to make additional changes. Just let me know. |
|
As you seem to be fine with it, I'd like to change all date parsing over to the new method. Should be a matter of only a few minutes. |
|
Go for it! |
… strings. This is just to be on the safe side, because how NIS handles time values doesn't seem completely logical/consistent.
|
Done. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.