Add more helper functions for RelayMessageOption. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlayher
requested changes
Oct 5, 2016
| @@ -294,3 +294,25 @@ func (r *RelayMessageOption) SetRelayMessage(p *RelayMessage) error { | |||
| *r = b | |||
| return nil | |||
| } | |||
|
|
|||
| // Get Client Server Message (e.g. Solicit Advertise ...) into this option (when hopcount = 0 of outer RelayMessage) | |||
| func (r *RelayMessageOption) GetClientServerMessage() (*Packet, error) { | |||
There was a problem hiding this comment.
Get isn't really idiomatic in Go. How about just ClientServerMessage?
| } | ||
|
|
||
| // Get RelayMessage (e.g. Relay Forward, Relay Reply) into this option (when hopcount > 0 of outer RelayMessage) | ||
| func (r *RelayMessageOption) GetRelayMessage() (*RelayMessage, error) { |
There was a problem hiding this comment.
Get isn't really idiomatic in Go. How about just RelayMessage?
| @@ -294,3 +294,25 @@ func (r *RelayMessageOption) SetRelayMessage(p *RelayMessage) error { | |||
| *r = b | |||
| return nil | |||
| } | |||
|
|
|||
| // Get Client Server Message (e.g. Solicit Advertise ...) into this option (when hopcount = 0 of outer RelayMessage) | |||
There was a problem hiding this comment.
Name this the same as the function.
Add commas between the message types you're listing.
Break to newline after 80 characters.
Add a period.
| return p, nil | ||
| } | ||
|
|
||
| // Get RelayMessage (e.g. Relay Forward, Relay Reply) into this option (when hopcount > 0 of outer RelayMessage) |
There was a problem hiding this comment.
Name this the same as the function.
Add commas between the message types you're listing.
Break to newline after 80 characters.
Add a period.
mdlayher
approved these changes
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding more helper function for RelayMessageOption.