Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RelayMessage + RelayMessageOption #4

Closed
wants to merge 6 commits into from
Closed

Add RelayMessage + RelayMessageOption #4

wants to merge 6 commits into from

Conversation

jerome-laforge
Copy link
Contributor

Hello,
Could you merge this PR for RelayMessage + RelayMessageOption?
Thx
Jérôme

@@ -253,3 +253,35 @@ func (n *NII) UnmarshalBinary(b []byte) error {

return nil
}

type RelayMessageOption []byte
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a documentation comment. Same for all other methods added to this file.

@jerome-laforge
Copy link
Contributor Author

Thx for review.
Plz, find all fix.

@jerome-laforge
Copy link
Contributor Author

Hello,
Did you planed to merge or reject this pull request?
Thx

@mdlayher
Copy link
Owner

mdlayher commented Jul 2, 2016

My apologies, I totally dropped the ball on this one. The PR looks good to me. Would you mind squashing into one commit, and then I will merge?

Thanks for your contribution.

@jerome-laforge
Copy link
Contributor Author

Hello,
No pb. Could you squash this PR by yourself?
That seems more easy for you as describe here:
https://help.github.com/articles/about-pull-request-merge-squashing/

Many thx.

2016-07-02 17:33 GMT+02:00 Matt Layher notifications@github.com:

My apologies, I totally dropped the ball on this one. The PR looks good to
me. Would you mind squashing into one commit, and then I will merge?

Thanks for your contribution.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AJhF7-H05UdIuIOM_r8PNQyj7UASJZp3ks5qRoTfgaJpZM4H0oNs
.

"The box said 'Requires Windows 95, NT, or better,' so I installed Linux."

@mdlayher
Copy link
Owner

mdlayher commented Jul 2, 2016

Merging as #5 since the web UI wasn't cooperating. Thanks for your contribution.

@mdlayher mdlayher closed this Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants