-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response to CRAN #30
Comments
Thanks @jennybc. I'm unsure whether this means they want those three packages to NOT invoke We could add an argument to read/write clip with May also warrant editing the "Developing with clipr" section of the README file. |
I’m going to try to debug this weekend (I think I can come close to replicating CRAN’s test env in Docker).
But, (IMO) we shld all avoid testing clipboard-y things on CRAN.
… On Dec 29, 2017, at 2:38 PM, Matthew Lincoln ***@***.***> wrote:
Thanks @jennybc. I'm unsure whether this means they want those three packages to NOT invoke clipr::write_clip, or whether they want changes in clipr itself to prevent operation in a non-interactive session?
We could add an argument to read/write clip with allow_non_interactive = FALSE that defaults to preventing use, but can be overridden. I hesitate to hardcode logic into clipr that completely prevents it from being used in non-interactive sessions - this seems like a decision that the user should get to make.
May also warrant editing the "Developing with clipr" section of the README file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Agreed. I believe that was my intent but I haven't checked yet to see exactly how I am violating this. |
I think if they wanted a change in clipr itself, you @mdlincoln would have gotten an email. I think it's the other packages that need to respond. But it's possible that there's some addition here that would help us all. In any case, whatever we do, it should be recorded as a best practice for using clipr in a CRAN package. |
@mdlincoln I like your idea. It's simple and most of all kind to the CRAN maintainers. So it would error if used in a non-interactive session without the opt-in? For |
Hey friends, I am wondering if this CRAN policy change will necessitate additional changes to those we have discussed. See: eddelbuettel/crp@0c28586 The policy seems to be saying writing to the clipboard is out of bounds with the qualification:
Edit: rereading Prof Brian Ripley's email in the context of this update, the last para takes on a new flavour. Now I wonder if they want us to request any access to the clipboard from the user? |
I will consult with some colleagues and be back in touch. |
If the user is an interactive session, I think it will be ok to copy to the clipboard if it is clear that that is the primary purpose of the function. For example, copying to the clipboard is the primary means by which It's a bit trickier for non-intearctive sessions - I'd say that you should not copy to the clipboard by default. Perhaps the easiest way is to add a |
I'm sorry to say other priorities meant I had to leave this fallow for some time. And reading over tidyverse/reprex#171 I guess I'm still a bit confused what CRAN's current thinking is on this subject? I'd like to push a small clipr update to address #31. Do we feel that coding in something explicitly to clipr is warranted, or would advice in the README about skipping tests on cran be sufficient? |
Added advice to README to not use in non-interactive session. |
cc @hrbrmstr @MilesMcBain
Bob, Miles, and I all got this email from Prof Brian Ripley recently:
I'm not working on this yet but we should coordinate our response. It is possible we might need/want something in clipr itself re: checking for interactive session and not being in tests. Regardless, it probably makes sense to discuss here.
The text was updated successfully, but these errors were encountered: