Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DmdDE and DdmDE labeling in HMM profile (typo?) #12

Closed
scubalaina opened this issue Apr 18, 2023 · 1 comment
Closed

DmdDE and DdmDE labeling in HMM profile (typo?) #12

scubalaina opened this issue Apr 18, 2023 · 1 comment

Comments

@scubalaina
Copy link

Hi there!
I'm using Defense-Finder for a project, and I noticed in the "DefenseFinder_rules.tsv" table that the system DmdDE requires a gene called DdmDE_DdmE - the prefix of the system and of the gene's being "Ddm" rather than "Dmd" as the system is called in the system column. I noticed that the HMM profile is also labeled this way (DdmDE_DdmE) and it has the same label within the xml file even though the xml file is titled DmdDE.xml . Is this is a typo and will it impact the ability to detect this system? Or should it still be detectable since the XML file and HMM profile name both contain the typo?

Thanks! :)

jeanrjc added a commit that referenced this issue Jan 31, 2024
@jeanrjc
Copy link
Contributor

jeanrjc commented Jan 31, 2024

Thanks for your report, we fixed that in version 1.2.4. Normally, it did not impact the results (the typo were everywhere and thus did not impact the parsing).

@jeanrjc jeanrjc closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants