Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show routes on Permissions list when advanced config is enabled #410

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

re3lex
Copy link
Contributor

@re3lex re3lex commented Oct 19, 2018

fix for issue described in this comment
#309 (comment)

@nomaanp
Copy link

nomaanp commented May 5, 2020

@mdmunir @sihar any update for this pull request?

@sihar
Copy link
Collaborator

sihar commented May 7, 2020

Sorry, for late response. I never use advanced config before.
I will test it in my free time.
Btw, you may test this PR and give your opinion :D

@nomaanp
Copy link

nomaanp commented May 14, 2020

Hi @sihar ,
I checked this changes and it is removing the routes from the permission page. I'm attaching the screenshot from @re3lex master and feature branch. Please take a look at it.

master branch(Issue):
image

feature branch (Fixed):
image

@nomaanp
Copy link

nomaanp commented May 27, 2020

Hi @sihar ,
I checked this changes and it is removing the routes from the permission page. I'm attaching the screenshot from @re3lex master and feature branch. Please take a look at it.

master branch(Issue):
image

feature branch (Fixed):
image

@sihar any update?

@sihar
Copy link
Collaborator

sihar commented Jun 5, 2020

thanks for your effort @nomaanp
I test this PR too and it works

@sihar sihar merged commit ae57d01 into mdmsoft:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants