Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mix of relative and absolutish paths #403

Merged
merged 1 commit into from
Jan 16, 2020
Merged

mix of relative and absolutish paths #403

merged 1 commit into from
Jan 16, 2020

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jan 16, 2020 •
edited by schalkneethling
Loading

To test, run npm run build and check.
But also, from within the interactive-examples project root, type:

npx install-local ~/dev/MOZILLA/MDN/bob && node node_modules/.bin/mdn-bob

fix #404 404

schalkneethling
schalkneethling approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! w00t! r+

@schalkneethling schalkneethling self-assigned this Jan 16, 2020
@schalkneethling schalkneethling merged commit b32e11a into mdn:master Jan 16, 2020
@peterbe peterbe deleted the mix-of-relative-and-absolutish-paths branch January 16, 2020 13:31
@schalkneethling schalkneethling mentioned this pull request Jan 16, 2020
Closed
@schalkneethling
Copy link
Contributor

🎉 This PR is included in version 1.1.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkneethling schalkneethling schalkneethling approved these changes

Assignees

@schalkneethling schalkneethling

Labels
None yet
Projects
None yet
Milestone
Ursula Rucker (S1 Q1 2020)
Development

Successfully merging this pull request may close these issues.

Bob cannot find /node_modules/
2 participants
@peterbe @schalkneethling