Skip to content

Commit

Permalink
Bump web-specs from v2.41.0 to v3.0.0 and adjust test accordingly (#2…
Browse files Browse the repository at this point in the history
…2185)

A new major of web-specs was released. Breaking change is that the presence of
a `nightly` property is no longer guaranteed. This happens for specs that do
not have a public URL, such as ISO specs.

The test that checks spec URLs needed to be adjusted accordingly.

Also, note the new version includes the Threading proposal for the WASM JS API,
which could thus be dropped from the list of exceptions.
  • Loading branch information
tidoust committed Feb 7, 2024
1 parent c774e78 commit f9481bb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"sinon": "^17.0.0",
"ts-node": "~10.9.1",
"typescript": "~5.3.2",
"web-specs": "^2.41.0",
"web-specs": "^3.0.0",
"yargs": "~17.7.0"
},
"scripts": {
Expand Down
11 changes: 4 additions & 7 deletions test/linter/test-spec-urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ const specsExceptions = [
// Remove if it is in the main ECMA spec
'https://github.com/tc39/proposal-regexp-legacy-features/',

// For the 'shared' flag in WebAssembly.Memory
// Remove if this spec will be merged with the main WebAssembly spec
'https://webassembly.github.io/threads/js-api/',

// See https://github.com/w3c/browser-specs/issues/305
// Features with this URL need to be checked after some time
// if they have been integrated into a real spec
Expand All @@ -47,11 +43,12 @@ const allowedSpecURLs = [
.filter((spec) => spec.standing == 'good')
.map((spec) => [
spec.url,
spec.nightly.url,
...spec.nightly.alternateUrls,
spec.nightly?.url,
...(spec.nightly ? spec.nightly.alternateUrls : []),
spec.series.nightlyUrl,
])
.flat(),
.flat()
.filter((url) => !!url),
...specsExceptions,
];

Expand Down

0 comments on commit f9481bb

Please sign in to comment.