Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-dark() CSS function supported by Opera 109, Edge 123 and Safari 17.5 (Beta) #22778

Closed
legendofmi opened this issue Apr 5, 2024 · 7 comments
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Comments

@legendofmi
Copy link

legendofmi commented Apr 5, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark

What specific section or headline is this issue about?

Browser support for light-dark() function

What information was incorrect, unhelpful, or incomplete?

Browser support is incorrect. The page says light-dark is not supported by Opera 109, Edge 123, and Safari 17.5 (beta) when all support it (support added on Chromium 123).

What did you expect to see?

light-dark() should show as supported by Opera, Edge, and Safari (beta).

Do you have any supporting links, references, or citations?

I tested the MDN page on Opera 109 and Edge 123 and both work. I couldn’t test on Safari 17.5 beta, but the support is mentioned on their release notes:
https://developer.apple.com/documentation/safari-release-notes/safari-17_5-release-notes

Opera 109:
image
109.0.5097.38 – 2024-04-02 blog post

  • CHR-9695 Update Chromium on desktop-stable-123-5097 to 123.0.6312.87

Edge 123:
image

Safari 17.5 (Beta):
I didn’t test it, but it’s on the release notes:
https://developer.apple.com/documentation/safari-release-notes/safari-17_5-release-notes

Do you have anything more you want to share?

No response

@bsmth bsmth transferred this issue from mdn/content Apr 5, 2024
@bsmth
Copy link
Member

bsmth commented Apr 5, 2024

Thanks for raising this. I've moved it into the BCD repo which is the right place to track this data.

This was introduced here:

And updated here:

I think the fix might be to remove the impl_url although there might be a display improvement with Opera and Edge mirroring true support when there's a version (support=true) in Chrome.

Compat table: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark#browser_compatibility

@legendofmi legendofmi changed the title light-dark() CSS function supported by Opera 109 and Edge 123 light-dark() CSS function supported by Opera 109, Edge 123 and Safari 17.5 (Beta) Apr 5, 2024
@legendofmi
Copy link
Author

Thanks! I just realised it’s also supported by Safari 17.5 Beta. I updated the title and the description.

@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Apr 5, 2024
@bsmth
Copy link
Member

bsmth commented Apr 9, 2024

I think the fix might be to remove the impl_url

This is not the case, the data from mirrored browsers is not updated yet. Here's the light-dark entry:

"light-dark": {
"__compat": {
"description": "<code>light-dark()</code>",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/color_value/light-dark",
"spec_url": "https://drafts.csswg.org/css-color-5/#light-dark",
"tags": [
"web-features:light-dark"
],
"support": {
"chrome": {
"version_added": "123",
"impl_url": "https://crbug.com/1490618"
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": "120"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "preview"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

And even though this was added in 109, Opera (desktop) versions in this repo are listed up to 108:
https://github.com/mdn/browser-compat-data/blob/main/browsers/opera.json#L816

@legendofmi
Copy link
Author

What about Safari? 17.5 seems to be already there. Is it just missing "version_added" for the light-dark entry?

@Elchi3
Copy link
Member

Elchi3 commented Apr 9, 2024

Safari 17.5 data is being updated in this PR: #22765

@legendofmi
Copy link
Author

legendofmi commented Apr 17, 2024

Safari 17.5 and Edge 123 are now showing as supported. The only one missing is Opera 109, but the browser was already added to the list (updated today):
https://github.com/mdn/browser-compat-data/blob/main/browsers/opera.json#L816

I will check again tomorrow and close the ticket if it shows as supported.

Update: MDN page is still showing light-dark() CSS function as not supported on Opera 109.

@legendofmi
Copy link
Author

MDN is now showing correctly the light-dark support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

No branches or pull requests

4 participants