Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update light-dark() support #22128

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Update light-dark() support #22128

merged 2 commits into from
Feb 6, 2024

Conversation

bramus
Copy link
Contributor

@bramus bramus commented Feb 1, 2024

(馃憢 Hi, Chrome DevRel here)

This PR adds update support for light-dark(), which will ship in Chrome 123

Marking as draft, as this PR depends on #22127 getting merged in first.

@github-actions github-actions bot added the data:css 馃帹 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Feb 1, 2024
@bramus bramus marked this pull request as ready for review February 5, 2024 16:12
@bramus
Copy link
Contributor Author

bramus commented Feb 5, 2024

Marking as ready for review now that #22127 got merged.

Elchi3
Elchi3 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 馃憤

@Elchi3 Elchi3 merged commit 1ad5daa into mdn:main Feb 6, 2024
6 checks passed
@bsmth bsmth mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:css 馃帹 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bramus @Elchi3