Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.ServiceWorkerGlobalScope.skipWaiting - Safari support #8811

Closed
bdenhollander opened this issue Jan 20, 2021 · 4 comments · Fixed by #8990
Closed

api.ServiceWorkerGlobalScope.skipWaiting - Safari support #8811

bdenhollander opened this issue Jan 20, 2021 · 4 comments · Fixed by #8990
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue 💯 Good issues for getting started with this project.

Comments

@bdenhollander
Copy link
Contributor

What information was incorrect, unhelpful, or incomplete?

skipWaiting() and Clients.claim() are listed as unsupported in Safari.

What did you expect to see?

Is ServiceWorker ready? linked in See also says they were added in 11.1

Did you test this? If so, how?

No

MDN page report details
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 21, 2021
@ddbeck ddbeck added the good first issue 💯 Good issues for getting started with this project. label Feb 2, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Feb 2, 2021

Thanks for reporting this, @bdenhollander.

Is ServiceWorker ready? linked in See also says they were added in 11.1

This appears to be correct. This matches up with the timeline suggested by https://bugs.webkit.org/show_bug.cgi?id=180329, too, since skipWaiting was implemented shortly after the release of Safari 11.

To fix this, I'd welcome a PR from you or another contributor that sets the Safari (11.1) and Safari for iOS (11.3) values in ServiceWorkerGlobalScope.json. Thanks again!

@bdenhollander
Copy link
Contributor Author

@ddbeck PR created. Is there a way to confirm whether Clients.claim() was also added in those versions?

https://developer.mozilla.org/en-US/docs/Web/API/Clients/claim

@ddbeck
Copy link
Collaborator

ddbeck commented Feb 4, 2021

@bdenhollander sorry, I forgot to follow up on that piece. I tested it and it looks like the entire Clients API shipped in 11.1/11.3. I'd welcome a PR for that too!

@ddbeck
Copy link
Collaborator

ddbeck commented Feb 4, 2021

I merged #8937 which fixes the api.ServiceWorkerGlobalScope.skipWaiting data. I decided to leave this open for claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue 💯 Good issues for getting started with this project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants