Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.headers.feature-policy.wake-lock to screen-wake-lock #10421

Merged

Conversation

sideshowbarker
Copy link
Collaborator

There is no “wake-lock” feature-controlled-policy defined in any current spec, and no “wake-lock” feature-controlled-policy was ever implemented in any browser. It’s instead called screen-wake-lock.

So this change renames http.headers.feature-policy.wake-lock to http.headers.feature-policy.screen-wake-lock.

The change also adds a spec URL for the feature.

Related MDN change: mdn/content#4873

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label May 10, 2021
sideshowbarker added a commit to mdn/content that referenced this pull request May 10, 2021
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change redirects the Feature-Policy/wake-lock article to the
Feature-Policy/screen-wake-lock article.

Related BCD change: mdn/browser-compat-data#10421
sideshowbarker added a commit to mdn/content that referenced this pull request May 10, 2021
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change redirects the Feature-Policy/wake-lock article to the
Feature-Policy/screen-wake-lock article.

Related BCD change: mdn/browser-compat-data#10421
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change renames http.headers.feature-policy.wake-lock to
http.headers.feature-policy.screen-wake-lock.

The change also adds a spec URL for the feature.

Related MDN change: mdn/content#4873
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/pp-wake-lock-rename-to-screen-wake-lock branch from 18c8dfe to 39337c8 Compare May 10, 2021 11:56
Elchi3
Elchi3 previously requested changes May 19, 2021
http/headers/feature-policy.json Outdated Show resolved Hide resolved
Elchi3 pushed a commit to mdn/content that referenced this pull request May 19, 2021
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change redirects the Feature-Policy/wake-lock article to the
Feature-Policy/screen-wake-lock article.

Related BCD change: mdn/browser-compat-data#10421
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@foolip foolip dismissed Elchi3’s stale review May 20, 2021 14:38

Suggestion applied

@foolip foolip merged commit fe00e07 into mdn:main May 20, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 20, 2021
ddbeck added a commit that referenced this pull request May 20, 2021
* Bump version to v3.3.4
* Add release note for #10353
* Add release note for #10347
* Add release note for #10336
* Add release note for #10415
* Add release note for #10417
* Add release note for #10449
* Add release note for #9933
* Add release note for #10354
* Add release notes for #6944
* Add release note for #10522
* Add release note for #10536
* Add release note for #10539
* Add release note for #10515
* Add release note for #10506
* Add release note for #10291
* Add release note for #10421
* Add release note for #10545
* Add stats
@sideshowbarker sideshowbarker deleted the sideshowbarker/pp-wake-lock-rename-to-screen-wake-lock branch May 21, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants