Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and complete the entries for focus({preventScroll}) parameters #11328

Merged
merged 1 commit into from Jun 30, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jun 30, 2021

The naming now matches the guideline:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features

Chromium support for this parameter for SVGElement came when the focus()
methods of HTMLElement and SVGElement were consolidated into
HTMLOrForeignElement. Before that only the HTMLElement variant had the
FocusOptions dictionary as an argument:
https://chromium.googlesource.com/chromium/src/+/5f506297541b9c0a041701401eeb133a16619bf9
https://storage.googleapis.com/chromium-find-releases-static/5f5.html#5f506297541b9c0a041701401eeb133a16619bf9

The other data is mirrored and IE is just assumed to be false.

The naming now matches the guideline:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features

Chromium support for this parameter for SVGElement came when the focus()
methods of HTMLElement and SVGElement were consolidated into
HTMLOrForeignElement. Before that only the HTMLElement variant had the
FocusOptions dictionary as an argument:
https://chromium.googlesource.com/chromium/src/+/5f506297541b9c0a041701401eeb133a16619bf9
https://storage.googleapis.com/chromium-find-releases-static/5f5.html#5f506297541b9c0a041701401eeb133a16619bf9

The other data is mirrored and IE is just assumed to be false.
@foolip foolip requested a review from queengooborg June 30, 2021 11:58
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 30, 2021
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foolip, this is looking good to me!

@queengooborg queengooborg merged commit 97d5e88 into mdn:main Jun 30, 2021
@foolip foolip deleted the options_preventScroll_parameter branch June 30, 2021 23:20
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 1, 2021
ddbeck added a commit that referenced this pull request Jul 1, 2021
* Bump version to v3.3.10

* Add release note for #10958

* Add release note for #11061

* Add release note for #11062

* Add release note for #11266

* Add release note for #11276

* Add release note for #11307

* Add release note for #11317

* Add release note for #11323

* Add release note for #11328

* Add release note for #11334

* Fix formatting

* Set release date

* Add stats
foolip added a commit to foolip/browser-compat-data that referenced this pull request Oct 20, 2021
queengooborg pushed a commit that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants