Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/move entries for Selection method parameters #11500

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jul 13, 2021

Rename two of them to be more consistent with other parameter entries in BCD and importantly to have underscores in the name.

The subfeatures for modify() are moved to collapse(). The modify() method doesn't have a node or offset parameter, and this data originates from #1738 where there appears to have been a mishap while splitting a "params" subfeature for collapse().

@foolip foolip requested a review from ddbeck July 13, 2021 09:25
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 13, 2021
@foolip
Copy link
Collaborator Author

foolip commented Jul 13, 2021

Since I sent #11506 today, I'll back out the experimental status changes. Those could all be done by the migration script.

Rename two of them to be more consistent with other parameter entries in
BCD and importantly to have underscores in the name.

The subfeatures for modify() are moved to collapse(). The modify()
method doesn't have a node or offset parameter, and this data originates
from mdn#1738 where
there appears to have been a mishap while splitting a "params"
subfeature for collapse().
@foolip foolip changed the title Fix Selection parameter entries and experimental status Rename/move entries for Selection method parameters Jul 13, 2021
@sideshowbarker sideshowbarker merged commit e3df947 into mdn:main Jul 14, 2021
@foolip foolip deleted the selection-cleanup branch July 14, 2021 10:36
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 15, 2021
ddbeck added a commit that referenced this pull request Jul 15, 2021
* Bump version to v3.3.11

* Add release note for #11502

* Add release note for #11499

* Add release note for #11100

* Add release note for #11101

* Add release note for #11152

* Add release note for #11355

* Add release note for #11361

* Add release note for #11438

* Add release note for #11520

* Add release note for #11452

* Add release note for #11481

* Add second release note for #11481

* Add release note for #11500

* Add release note for #11524

* Add release note for #11413

* Add release note for #11414

* Add release date

* Add stats

* Fix formatting
@ddbeck ddbeck removed their request for review July 16, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants