Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF91 Window.clientInformation as alias for .navigator #11690

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

hamishwillee
Copy link
Collaborator

window.clientInformation is an alias of Window.navigator.

Historically this was non-spec but was present in Chrome (and others using same engine) and also Safari (since at least Feb 2017 according to whatwg/html#2379).
It was added to the spec here as a "legacy alias" in this PR,
FF91 added it as an alias in https://bugzilla.mozilla.org/show_bug.cgi?id=1717072. It is default enabled (but there is a preference to allow it to be disabled easily if needed).

This PR simply adds the alias information as a new version with "alternative_name": "clientInformation" for Firefox.

  • Is this correct?
  • There is a preference but it is set true by default. Do I need to add a flag for it in this case (I have assumed not).

As per the notes, Chromium based browsers (Opera, Chrome, Edge etc.) and Safari supported this even though non-spec since Feb 2017. However I have no idea of what versions this would have been added. How would you like to handle this? Can you help find versions, or could we assume that for those platforms the alternative name as been there since day 1 (just add a new version for chrome etc with the same release number and the alterative name)?

FYI, this is one of the items linked in #7585

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 23, 2021
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip foolip merged commit d249482 into mdn:main Jul 23, 2021
foolip added a commit that referenced this pull request Jul 23, 2021
queengooborg pushed a commit that referenced this pull request Jul 23, 2021
* Add clientInformation (alias of navigator) for all browsers

Follow-up to #11690.

* Add real/range versions
@hamishwillee hamishwillee deleted the ff91_window_client_information branch July 25, 2021 23:37
@hamishwillee
Copy link
Collaborator Author

@foolip Thanks for merging. This change was correct but there was a question in description as well.

Specifically the alternative name has also been around in chromium etc since at least 2017, even though it was non-spec at that time. I don't know what versions though. The question was basically best way to mark those up - ie same way but should version be true or the first version in which the API appears?

@foolip
Copy link
Collaborator

foolip commented Aug 9, 2021

@hamishwillee sorry I missed the question, but I also realized the problem and sent #11696 at the same time as I reviewed this, but didn't comment here. (You can see the backlink but that doesn't trigger a notification.)

@hamishwillee
Copy link
Collaborator Author

Thanks @foolip ! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants