Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox versions for PerformanceEntry API #12033

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Aug 17, 2021

This PR adds real values for Firefox and Firefox Android for the PerformanceEntry API, based upon browser bug history.

Bugs:
https://bugzil.la/822480
https://bugzil.la/1047848

This PR adds real values for Firefox and Firefox Android for the `PerformanceEntry` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.9).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PerformanceEntry
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 17, 2021
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original "25" for Firefox Android came from #1298 with no discussion about the version that I can see.

https://developer.mozilla.org/en-US/docs/Web/API/Performance#browser_compatibility says performance.getEntries() and a bunch of other things were shipped in Firefox 35, but that implies support for PerformanceEntry since that's what's returned. Can you double check which is correct and change things to be consistent?

@queengooborg
Copy link
Collaborator Author

I think the original "25" was either a mistake (copied from Chrome Android), or bad data from the wiki tables (which could have also been caused by someone copying the value from Chrome Android).

Regarding the values in this PR however, it seems this is a bit of a problem with our test. I'm submitting a PR to the collector now to resolve this and use getEntries() instead!

@foolip
Copy link
Collaborator

foolip commented Aug 26, 2021

@vinyldarkscratch can this data be updated now based on the collector fixes?

@queengooborg
Copy link
Collaborator Author

The new collector updates will fix this, yes! Since my laptop's out of commission for a while though, it'll be some time before I can get updated results.

@queengooborg
Copy link
Collaborator Author

Hmmm...the recent collector results (v3.1.12) also indicate support in Firefox 38. Looks like I'll need to revise the custom test again and try to generate an entry before getting any of them, probably.

@queengooborg
Copy link
Collaborator Author

https://bugzilla.mozilla.org/show_bug.cgi?id=822480 marks this interface as implemented in Firefox 31. Based upon the collector results for getEntries(), I'm assuming that it was behind a flag to begin with, so I'll set this to "35" to match.

@queengooborg queengooborg marked this pull request as ready for review September 16, 2021 21:44
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching the methods that returnPerformanceEntry makes sense!

@foolip foolip merged commit aab303f into mdn:main Sep 17, 2021
@queengooborg queengooborg deleted the api/PerformanceEntry/firefox branch September 17, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants