Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete RTCIceCandidateInit dictionary from BCD #12292

Merged
merged 2 commits into from Sep 22, 2021
Merged

Delete RTCIceCandidateInit dictionary from BCD #12292

merged 2 commits into from Sep 22, 2021

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Sep 7, 2021 •
edited

This PR removes the RTCIceCandidateInit dictionary from BCD.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 7, 2021
@queengooborg queengooborg mentioned this pull request Sep 7, 2021
Merged
@queengooborg queengooborg added needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation needs-release-note 📰 and removed needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Sep 7, 2021
foolip
foolip requested changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opinions, but wouldn't be offended if you ask for a second opinion on this :)

api/RTCIceCandidate.json Outdated Show resolved Hide resolved
@foolip
Copy link
Collaborator

foolip commented Sep 22, 2021

@queengooborg I'll leave it to you to merge in case you want to rewrite the commit message.

@queengooborg queengooborg merged commit 9c61e78 into mdn:main Sep 22, 2021
@queengooborg queengooborg deleted the api/RTCIceCandidateInit branch September 22, 2021 22:40
@queengooborg queengooborg mentioned this pull request Oct 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@queengooborg @foolip