Add compat data for Slotable api #1232
Conversation
teoli2003
added
the
data:api 🐇
Elchi3
added this to In Progress / Review Needed
in Migration of compat data from MDN pages
api/Slotable.json
Outdated
| "version_added": null | ||
| }, | ||
| "firefox": { | ||
| "version_added": true |
There was a problem hiding this comment.
This should be:
{
"version_added": "58",
"flags": [
{
"type": "preference",
"name": "dom.webcomponents.enabled",
"value_to_set": "true"
}
]
}
api/Slotable.json
Outdated
| "version_added": true | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": true |
api/Slotable.json
Outdated
| ] | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": true |
There was a problem hiding this comment.
You missed the information for Firefox for Android, this should be the same as in Firefox for Desktop.
There was a problem hiding this comment.
The compat data on here needs updating, as the old-fashioned table on the Slotable MDN page isn't quite right.
Since this was implemented in most browsers as part of the same effort as the rest of the Shadow DOM v1 spec, I'd fully expect this to have the same support data as HTMLSlotElement. Copy the support data from https://github.com/chrisdavidmills/browser-compat-data/blob/dc6d108eb722a254774a9be7dcfe1f2463ee5e90/api/HTMLSlotElement.json, for both the Interface and its property.
Thanks!
|
Sorry for the messiness, I forgot to pull before pushing. And thanks for the explanation; I'm still learning and it's a huge help. |
|
No worries! It is a complex process; it took me a while to get used to as well. And the Web components support data is not the simplest. Thanks for the contribution ;-) |
Elchi3
moved this from MDN page updates needed
to Done
in Migration of compat data from MDN pages
No description provided.