Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: "start", "end" values in flex context #12602

Merged
merged 12 commits into from Jan 12, 2022
Merged

css: "start", "end" values in flex context #12602

merged 12 commits into from Jan 12, 2022

Conversation

ZerdoX-x
Copy link
Contributor

@ZerdoX-x ZerdoX-x commented Sep 27, 2021

Summary

Removing wrong & adding support data: "start" and "end" values in flex context (align-self, align-items, align-content, justify-content)

Updated browsers:
Safari, safari mobile, opera mobile, samsung internet – Incorrect support data removed
Opera 79 – Support data added

Test results and supporting details

Tested by me on Linux in WebKitGTK 2.32.4 and my friends on OSX and IOS (different safari versions)
Tested in Opera 79.0.4143.50
Tested in Opera Mobile 65.1.3381.61266
Tested in Samsung Internet 15

align-self: end; demo: https://codepen.io/zerdox-x/pen/rNwQXRe
align-items: end; demo: https://codepen.io/zerdox-x/pen/MWoxXdK
align-content: end; demo: https://codepen.io/zerdox-x/pen/powYZoj
justify-content: end; demo: https://codepen.io/zerdox-x/pen/JjJeVyR

with values start, end are not supported
@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Sep 27, 2021
@lukewarlow
Copy link
Contributor

The support data for some of the other Chromium based browsers is incorrect too. Specifically Opera, Opera Android and Samsung Internet.

@ZerdoX-x ZerdoX-x changed the title safari css: "align-self", "justify-content" with "end", "start" values css: "start", "end" values in flex context Sep 30, 2021
@ZerdoX-x
Copy link
Contributor Author

Thank you. So this should be ok now. Feel free to report info if you'll find more issues with this.

@ZerdoX-x
Copy link
Contributor Author

Let me know if something holding back from reviewing & merging

@ZerdoX-x
Copy link
Contributor Author

ZerdoX-x commented Oct 13, 2021

Thank you so much. I've tested it in opera mobile by myself now.
Changes after review:
Opera support 44 => 79
Opera mobile support 44 => false
Whole section across all 4 files is the same now (including notes)


And I am not sure that support of this values in Opera has been added exactly in 79. Maybe a bit earlier?

@lukewarlow
Copy link
Contributor

Opera 79 correlates to Chrome 93 which is what the existing support data says so I'm assuming it's correct.

Not sure if the notes should be kept for the version_added false entries (Samsung and Opera Android) but one of the maintainers will let you know if that's an issue when they review.

@ZerdoX-x
Copy link
Contributor Author

ZerdoX-x commented Oct 13, 2021

There were some notes in some files but I guess this data shouldn't differ across css properties as this is one feature so I removed that notes already.

@ZerdoX-x
Copy link
Contributor Author

So can someone review this too please?

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZerdoX-x and thanks for this PR. I see it's your first to the project—welcome! I do think we need to do something about the old notes. I've left a line comment to try to explain. Let me know if there are any questions. Thanks again!

css/properties/align-content.json Show resolved Hide resolved
@ZerdoX-x
Copy link
Contributor Author

@ddbeck here you are

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 757b8ff into mdn:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants