Mark SubmitEvent as partially supported in Safari 15 #12756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
|
The issue with the linter should be fixed if you rebase with main :) |
gilmoreorless
force-pushed
the
safari-submitevent-submitter
branch
from
04733c5
to
d0f19ea
Compare
|
Thanks @lukewarlow, I've rebased and modified the data to show that it's fully supported in the Tech Preview. 😃 |
ddbeck
requested changes
Oct 19, 2021
|
Thanks @ddbeck, fixed now. I'd copied the note format from Safari entries in other files. I agree that your version works better though. |
The `SubmitEvent` constructor is fully supported, but the `submitter` property only partially works (fixed in Tech Preview).
gilmoreorless
force-pushed
the
safari-submitevent-submitter
branch
from
acdbfb2
to
f3636bd
Compare
|
Rebased to fix a merge conflict from #13142. I've left the fully-fixed version for |
queengooborg
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
SubmitEventconstructor is fully supported, but thesubmitterproperty only partially works: https://webkit.org/b/229660The bug is fixed in Tech Preview 132, but it missed the release cut for Safari 15.
I would have added an extra(Edit: Fixed)version_added: "preview"section, but got bitten by #12663 when running linting locally.Test results and supporting details
Tested manually in Safari 15 (macOS and iOS).
Release notes:
submitterin TP 132: https://webkit.org/blog/11971/release-notes-for-safari-technology-preview-132/Related issues
This will cause a merge conflict with the TP info provided by #12439