Merge RTCConfiguration dict into RTCPeerConnection

[queengooborg]

This PR removes RTCConfiguration from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

[foolip]

There's also a setConfiguration() method which takes this dictionary as an argument. I don't see any discussion about whether parameters should be added there too, or perhaps instead of in the constructor. Making a deliberate decision on this would be good.

[queengooborg]

I don't think that we have a set convention for this scenario, but in the MDN changes, I have made it so that the page for setConfiguration() has a link to the constructor to list the configuration options and their functions. Thus, users will head to the constructor's documentation to find more information about these parameters. As such, I think it makes sense to just keep the BCD data here!

[foolip]

I see, https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/setConfiguration#parameters looks good!

[foolip]

I don't trust the existing data here much at all. I double checked two, can you find the commits that added the rest in Chromium to double check?

[foolip]

I don't trust the original data at all here, so would like to see sources for at least all Chromium statements.

[foolip]

@queengooborg can you turn this into a draft if it still needs research?

[queengooborg]

It's quite possible that our existing data is incorrect, but I'm not yet sure how to check it and find out what the accurate versions are. I think we can probably implement some form of test in the collector, but to do so, we'll need to fix the properties and where they're located. I'll open up an issue to remind myself!

In summary: I'm lazy and would like to defer fixing the version numbers to future me... 😛

[caugner]

This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

@queengooborg Maybe this is obvious, but is this mentioned anywhere in the contribution or data docs?

edit: If I interpret the changes correctly, this PR is essentially merging RTCConfiguration into RTCPeerConfiguration, right?

[caugner]

IMO it would be good to update the PR title, as RTCConfiguration is not just removed, but merged/integrated into RTCPeerConnection.

[queengooborg]

PR title has been updated and this is ready for review again!

[foolip]

I've filed #16595 about data that's probably wrong here.