Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MediaStreamAudioSourceOptions API from BCD #13523

Merged
merged 1 commit into from Nov 15, 2021
Merged

Remove MediaStreamAudioSourceOptions API from BCD #13523

merged 1 commit into from Nov 15, 2021

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Nov 14, 2021 •
edited

This PR removes the MediaStreamAudioSourceOptions dictionary from BCD.

@queengooborg
Remove MediaStreamAudioSourceOptions API from BCD
ca09512 
This PR removes the irrelevant `MediaStreamAudioSourceOptions` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Nov 14, 2021
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 14, 2021
@queengooborg queengooborg mentioned this pull request Nov 14, 2021
Merged
foolip
foolip approved these changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches

browser-compat-data/api/MediaStreamAudioSourceNode.json

Lines 51 to 104 in d9bd6e2

"MediaStreamAudioSourceNode": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/MediaStreamAudioSourceNode/MediaStreamAudioSourceNode",
"spec_url": "https://webaudio.github.io/web-audio-api/#dom-mediastreamaudiosourcenode-mediastreamaudiosourcenode",
"description": "<code>MediaStreamAudioSourceNode()</code> constructor",
"support": {
"chrome": {
"version_added": "55",
"notes": "Before Chrome 59, the default values were not supported."
},
"chrome_android": {
"version_added": "55",
"notes": "Before Chrome 59, the default values were not supported."
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": "53"
},
"firefox_android": {
"version_added": "53"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "42"
},
"opera_android": {
"version_added": "42"
},
"safari": {
"version_added": "14.1"
},
"safari_ios": {
"version_added": "14.5"
},
"samsunginternet_android": {
"version_added": "6.0",
"notes": "Before Samsung Internet 7.0, the default values were not supported."
},
"webview_android": {
"version_added": "55",
"notes": "Before Chrome 59, the default values were not supported."
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
pretty well so no subfeatures are necessary. But please wait for the content PR to land first.

@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Nov 15, 2021
@queengooborg
Copy link
Collaborator Author

Content PR was just merged! Merging now since it has been approved.

@queengooborg queengooborg merged commit 656e2d0 into mdn:main Nov 15, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Nov 16, 2021
@ddbeck
Add release note for mdn#13523
ad13729
ddbeck added a commit that referenced this pull request Nov 16, 2021
@ddbeck
Prepare release v4.0.11 (#13547)
4977eec 
* Bump version to v4.0.11

* Add release date

* Add release note for #12879

* Add release note for #13424

* Add release note for #13479

* Add release note for #13486

* Add release note for #13523

* Hoist from previous release

* Add stats

* Copyedit

* Fix order
@ddbeck ddbeck mentioned this pull request Nov 17, 2021
Closed
@queengooborg queengooborg mentioned this pull request Dec 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@queengooborg @foolip @ddbeck