Complete nodejs data for URL and URLSearchParams #13655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
gilmoreorless
commented
Nov 20, 2021
Comment on lines
+146
to
+154
| "nodejs": [ | ||
| { | ||
| "version_added": "10.0.0" | ||
| }, | ||
| { | ||
| "version_added": "7.0.0", | ||
| "notes": "Has to be imported from the URL module." | ||
| } | ||
| ], |
There was a problem hiding this comment.
This information for the URL constructor is copied from the top-level object.
gilmoreorless
commented
Nov 20, 2021
Comment on lines
-92
to
-101
| "nodejs": [ | ||
| { | ||
| "version_added": "7.10.0" | ||
| }, | ||
| { | ||
| "version_added": "7.5.0", | ||
| "partial_implementation": true, | ||
| "notes": "Only string as <code>init</code> object supported." | ||
| } | ||
| ], |
There was a problem hiding this comment.
I removed the note because the information is covered by the later-added USVString, record, and sequence sub-properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13170. This fills in
trueand missingnodejsvalues forURLandURLSearchParams.Test results and supporting details
Most of the data came from the "history" section of the documentation.
Local testing also revealed the oddity of
URL#searchParamsreturning a dummy object in7.0.0beforeURLSearchParamswas properly implemented in7.5.0.