Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete nodejs data for MessagePort #13656

Merged
merged 2 commits into from Nov 22, 2021

Conversation

gilmoreorless
Copy link
Contributor

@gilmoreorless gilmoreorless commented Nov 20, 2021

Summary

Part of #13170. This fills in a true value for nodejs in MessagePort, but also updates some partially-supported APIs to full support.

Test results and supporting details

History section in the documentation: https://nodejs.org/dist/latest-v16.x/docs/api/worker_threads.html#class-messageport

Changelog entry for full support in 14.7.0: https://nodejs.org/en/blog/release/v14.7.0/

(SEMVER-MINOR) make MessagePort inherit from EventTarget

This required adding the 14.7.0 release to the nodejs.json file. Let me know if that should be split out to a separate PR.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 20, 2021
@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Nov 20, 2021
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit 4b31401 into mdn:main Nov 22, 2021
@gilmoreorless gilmoreorless deleted the nodejs-missing-messageport branch November 22, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants