Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete nodejs data for Performance #14666

Merged
merged 4 commits into from Jan 29, 2022
Merged

Complete nodejs data for Performance #14666

merged 4 commits into from Jan 29, 2022

Conversation

gilmoreorless
Copy link
Contributor

Summary

This fills in the null and missing nodejs versions for these entries:

  • api.Performance.eventCounts
  • api.Performance.measureUserAgentSpecificMemory
  • api.PerformanceEntry.duration
  • api.PerformanceMark.PerformanceMark
  • api.PerformanceMark.detail
  • api.PerformanceMeasure.detail
  • api.PerformanceObserver.PerformanceObserver
  • api.PerformanceObserver.worker_support

Additionally, support for api.Performance.toJSON was added in Node 16.1.0, so I've updated that entry as well.

Test results and supporting details

  • Most of the data comes from the "history" section of each API in the documentation
  • Local testing was done to verify the results. The PerformanceMark constructor is not listed in the official documentation, but can be imported from the perf_hooks module from v16.0.0 onwards.
  • Worker support in general was added to Node in 10.5.0, which is the version we list for other APIs' worker_support entries.

Related issues

Part of #13170

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 26, 2022
@gilmoreorless gilmoreorless mentioned this pull request Jan 26, 2022
Merged
@gilmoreorless
Copy link
Contributor Author

Currently blocked by #14667

@queengooborg
Copy link
Collaborator

I merged #14667, so this PR is ready after a quick merge of the latest main!

@gilmoreorless
Copy link
Contributor Author

Thanks @queengooborg, I've rebased the branch.

queengooborg
queengooborg approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@queengooborg queengooborg merged commit 54154f1 into mdn:main Jan 29, 2022
@gilmoreorless gilmoreorless mentioned this pull request Jan 29, 2022
Closed
@gilmoreorless gilmoreorless deleted the nodejs-missing-performance branch January 29, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilmoreorless @queengooborg