Adding data for HTMTableHeaderCellElement #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
data:api 🐇
ddbeck
requested changes
Jun 12, 2018
There was a problem hiding this comment.
Thanks for this PR, @chrisdavidmills! A little adjustment to the notes would be good here, but otherwise ready to go
api/HTMLTableHeaderCellElement.json
Outdated
| "support": { | ||
| "webview_android": { | ||
| "version_added": false, | ||
| "notes": "Members of the HTMLTableHeaderCellElement interface now implemented on HTMLTableCellElement." |
There was a problem hiding this comment.
This note seems good, but I think it would be a little more readable with HTMLTableHeaderCellElement and HTMLTableCellElement in <code> tags
|
Change made. |
ddbeck
approved these changes
Jun 13, 2018
|
Thanks, @chrisdavidmills! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I'm really not sure if this is the right way to represent this. The trouble is that this interface existed at some point, but it was completely removed from browsers and the spec a couple of years ago (see whatwg/html#1115), and its members are now implemented on HTMLTableCellElement (see #1526).
The same problems will be seen for HTMLTableDataCellElement too (#1534 ) too.
We could just kill it with fire, but this is not the MDN way ;-)