Demix animation events from GlobalEventHandlers #16531
Conversation
github-actions
bot
added
the
data:api 🐇
|
This pull request has merge conflicts that must be resolved before it can be merged. |
queengooborg
added
the
needs content update 📝
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
|
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Like with most bubbling events we have too many entries. I've read https://drafts.csswg.org/css-animations/#events and Chromium's implementation, and it looks like the event target is always an Element for these events. Can you move the 4 entries to Element and remove everything else?
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
queengooborg
removed
the
needs content update 📝
This PR demixes the
animationevent handlers from the GlobalEventHandlers mixin. There were some odd discrepancies between the events already on the interfaces. Here's what I found:The
animationevents were set to43, however the event handlers said they were added in43only onWindowthen79everywhere else. After some further research, it appears that the events were added in43, and then the event handlers were added later other than for Window.Additionally, the
Windowevent had prefixes added to them, which came from #3563. However, this appears to have been a mistake; the same PR added the features forDocumentandHTMLElementwhich don't have the prefix data, and the description indicates intention to remove it. I've removed it here.