Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix securitypolicyviolation event from GlobalEventHandlers #16728

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the securitypolicyviolation event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2022
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 19, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

api/HTMLElement.json Outdated Show resolved Hide resolved
api/Window.json Outdated Show resolved Hide resolved
@foolip
Copy link
Collaborator

foolip commented Jun 22, 2022

Per https://w3c.github.io/webappsec-csp/#report-violation and https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/csp/execution_context_csp_delegate.cc;l=287-294;drc=169c6cc102b39295a5bfe2f2a176b42b1c2fe2c4 the possible event targets are Element, Document and WorkerGlobalScope.

The entry on Element already exists, but can you add/update the other two to have matching data?

@queengooborg
Copy link
Collaborator Author

Are there any other changes that need to be made for this PR?

@foolip
Copy link
Collaborator

foolip commented Jul 8, 2022

Yes, there are differences in the data across the 3 entries that need to be explained or fixed:

  • Chrome 41 or 97?
  • Edge 15 or 97?
  • Firefox 63 or 93?
  • Safari 10 or "preview"?

I would expect that the events on Element and Document were implemented at the same time, but maybe the event on WorkerGlobalScope came later.

Digging through source might be simpler than testing in this case.

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 14, 2022
@queengooborg queengooborg merged commit 27a44d6 into mdn:main Jul 14, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/securitypolicyviolation branch July 14, 2022 13:14
@queengooborg
Copy link
Collaborator Author

I merged this PR while there were changes requested because I wanted to defer version number updates to a future PR so it wouldn't block the demixing of GEH. I do plan to follow-up on this using results from the collector!

@foolip
Copy link
Collaborator

foolip commented Jul 14, 2022

I merged this PR while there were changes requested because I wanted to defer version number updates to a future PR so it wouldn't block the demixing of GEH. I do plan to follow-up on this using results from the collector!

Can you file an issue about this data? We can't trust the collector because it's based on the properties, and in particular the absence of changes suggested by the data doesn't imply that the questions in #16728 (comment) have been answered, so probably it will never come up organically from collector work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants