Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data for MathML global attributes #16995

Merged
merged 3 commits into from Jul 17, 2022
Merged

Add data for MathML global attributes #16995

merged 3 commits into from Jul 17, 2022

Conversation

fred-wang
Copy link
Contributor

Summary

This is adding data for MDN articles describing MathML global attributes.

Test results and supporting details

This was done by checking the source code of browsers, bug entries as well as the commits.

Note: npm test fails with "version_added: 'true' is NOT a valid version number" but that seems to be what other files do to.

Related issues

mdn/content#17812

@fred-wang
Add data for MathML global attributes
cce4256 
This is adding data for new pages added in
mdn/content#17812
@github-actions github-actions bot added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Jul 14, 2022
@fred-wang
Copy link
Contributor Author

cc @teoli2003

@queengooborg
Copy link
Collaborator

Hey @fred-wang, thank you for your PR, and welcome to BCD!

To answer your comment about true being disallowed as a version_added, it is because a long-term goal for BCD is to remove all "non-real values" (that is, data without a specific version number), and mathml is one of the categories where this is enforced.

I'd be more than happy to help research version numbers for Firefox and Safari for you, if you'd like!

@fred-wang
Copy link
Contributor Author

Thanks for the information @queengooborg ; I should be able to figure out which version these attributes were implemented. I'll update the PR later to get rid of the failures with version_added.

@fred-wang
Copy link
Contributor Author

@queengooborg I've updated the PR but I'm not sure whether there is an easy way to get Safari's version from the WebKit commit.

@queengooborg
Copy link
Collaborator

In our browser data, we record every WebKit version for each Safari release -- check out browsers/safari.json, which should help with that!

@fred-wang
Copy link
Contributor Author

@queengooborg Great, thanks I think I've updated the data and tests pass locally now.

Note that I haven't added data for MathML global attributes that are currently using the equivalent HTML pages. However, I've done that for the dir attribute because its syntax is slightly different from HTML's dir and I plan to create https://developer.mozilla.org/docs/Web/MathML/Global_attributes/dir

@fred-wang fred-wang mentioned this pull request Jul 15, 2022
Merged
3 tasks
queengooborg
queengooborg approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is LGTM! I agree with not duplicating HTML global attributes here. Welcome to BCD, @fred-wang! 🎉

@queengooborg queengooborg merged commit c1750dc into mdn:main Jul 17, 2022
@fred-wang
Copy link
Contributor Author

@queengooborg Thanks!

@fred-wang fred-wang deleted the mathml-global-attributes branch July 18, 2022 06:12
@fred-wang
Copy link
Contributor Author

@queengooborg extra question: when is that new data going to be available from MDN? even when testing MDN locally, data is not reachable.

@queengooborg
Copy link
Collaborator

I release a new version of BCD every Tuesday, and it usually gets updated in Yari within the following two days. These changes will go live by the end of the week, promise!

@fred-wang
Copy link
Contributor Author

Thanks for the information.

@fred-wang fred-wang mentioned this pull request Jul 19, 2022
Merged
fred-wang added a commit to fred-wang/browser-compat-data that referenced this pull request Jul 21, 2022
@fred-wang
Remove data for MathML global attributes from MathML elements.
c7d032d 
The information for MathML global attributes has been added to a
separate file [1] so it does not need to be repeated for each
individual MathML element anymore. That also makes things
consistent with what HTML does. Note that the case of mstyle is
handled in [2].

[1] mdn#16995
[2] mdn#17043
@fred-wang fred-wang mentioned this pull request Jul 21, 2022
Merged
queengooborg added a commit that referenced this pull request Aug 9, 2022
@fred-wang @queengooborg
Remove data for MathML global attributes from MathML elements. (#17057)
8fc2222 
The information for MathML global attributes has been added to a
separate file [1] so it does not need to be repeated for each
individual MathML element anymore. That also makes things
consistent with what HTML does. Note that the case of mstyle is
handled in [2].

[1] #16995
[2] #17043

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fred-wang @queengooborg