Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Safari versions for Animation API #17021

Closed

Conversation

queengooborg
Copy link
Collaborator

This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the Animation API, based upon results from the mdn-bcd-collector project (v6.0.8).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Animation

Check out the collector's guide on how to review this PR.

Note: due to issues with update-bcd, these changes were performed manually by comparing the results output for Safari 10.0 and 10.1.

This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the `Animation` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v6.0.8).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Animation

_Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._

Note: due to issues with `update-bcd`, these changes were performed manually by comparing the results output for Safari 10.0 and 10.1.
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 16, 2022
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the data for https://developer.mozilla.org/en-US/docs/Web/API/Element/animate. Maybe the interface was exposed before it could actually be used for anything?

@foolip
Copy link
Collaborator

foolip commented Jul 19, 2022

Note: due to issues with update-bcd, these changes were performed manually by comparing the results output for Safari 10.0 and 10.1.

Can you investigate those issues? Given WebKit/WebKit@b206b8c + WebKit/WebKit@28472b3 I suspect that these interfaces were exposed for one release by accident. That would lead to the collector bailing here:

https://github.com/foolip/mdn-bcd-collector/blob/3e6b807aa77165dbb47cce8ef7356e5ba10ab6b6/update-bcd.ts#L297-L300

I think fixing this issue will be necessary for openwebdocs/project#85, or at least we have to be able to list the errors even if the collector can't fix them.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to avoid accidental merge.

@queengooborg
Copy link
Collaborator Author

Ah, yep, that's what's going on. Because two of the properties were supported in that early version of Safari as well, the collector was setting them to Safari 10.1. Between 10.1 and 13.1, they all returned null, so the collector didn't know what to do.

@queengooborg queengooborg deleted the api/Animation/safari-corrections branch July 19, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants