Add slotchange event. #1739
Closed
Add slotchange event. #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested changes
Apr 11, 2018
| @@ -0,0 +1,49 @@ | |||
| { | |||
There was a problem hiding this comment.
Flagging @Elchi3 here — is this the correct way to add an actual event to BCD (as opposed to a DOM event object?)
There was a problem hiding this comment.
I mean, shouldn't we put events in a separate events folder? And maybe have the JSON structure as events.slotchange or similar?
There was a problem hiding this comment.
Yes, please hold on with events for now. See the discussion in #935.
| @@ -0,0 +1,49 @@ | |||
| { | |||
| "api": { | |||
| "slotChange": { | |||
Elchi3
added
the
not ready ⛔
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.