Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Javascript browser compat to new schema #174

Closed
wants to merge 2 commits into from

Conversation

teoli2003
Copy link
Member

Need PR #170 to land first

Will likely need a trivial rebase after it has landed.

@Elchi3
Copy link
Member

Elchi3 commented May 9, 2017

This is not ready to be merged yet.

  • Can't land without the MDN KumaScript macro being changed to work with the new schema. The Promise test pages on MDN make use of the data in the old schema.
  • "desc": "Basic support" is present here as well. We might want to add a commit that removes these.
  • Needs a rebase.

@Elchi3 Elchi3 removed this from In Progress / Review Needed in Migration of compat data from MDN pages May 10, 2017
@Elchi3
Copy link
Member

Elchi3 commented May 16, 2017

Also, I think the namespace should be "javascript.builtins.Promise" or "javascript.api.Promise".
There will be cases like:
"javascript.api.Function"
"javascript.operators.function"
"javascript.statements.function"

@Elchi3 Elchi3 added this to In Progress / Review Needed in Migration of compat data from MDN pages May 19, 2017
@Elchi3
Copy link
Member

Elchi3 commented May 28, 2017

--> #206

@Elchi3 Elchi3 closed this May 28, 2017
@Elchi3 Elchi3 removed this from In Progress / Review Needed in Migration of compat data from MDN pages May 28, 2017
@queengooborg queengooborg added data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript duplicate 👯‍♀️ Duplicate issues or pull requests. This one is closed in favor of the other issue or pull request. invalid 🚫 Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! labels Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript duplicate 👯‍♀️ Duplicate issues or pull requests. This one is closed in favor of the other issue or pull request. invalid 🚫 Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants