Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider outline not following border-radius a partial implementation #17598

Merged
merged 2 commits into from Oct 31, 2022

Conversation

cpmsmith
Copy link
Contributor

Summary

This information is currently in the data, but as a note. It's not tagged to specific versions, either, which means when scanning, for instance, the browser compatibility table on MDN, the Safari column looks the same as browsers which have implemented this. Now that the spec says this should be done, I think it's reasonable to consider it a partial implementation if it isn't done.

image

image

Test results and supporting details

The WebKit bug in the note got marked as a duplicate of this bug, so I updated the link.

Also note that on the browsers that have fixed it, I didn't put a version_removed property on the partial implementations, only a newer support statement. That seems to be valid, and I'm not totally clear on the semantics of having it vs. not having it, so let me know if I should add it.

Related issues

Related to #12760, Fyrd/caniuse#6099

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Aug 29, 2022
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thank you for your PR and welcome to BCD!

I'm down for converting this from a note to partial_implementation; it's a pretty severe caveat. We should also add a version_removed for when the partial implementation no longer applies.

css/properties/outline.json Show resolved Hide resolved
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@queengooborg queengooborg merged commit d35fee0 into mdn:main Oct 31, 2022
@kylemh
Copy link

kylemh commented Jul 26, 2023

Hello! This should be updated to show just for versions below 16.4: https://webkit.org/blog/13966/webkit-features-in-safari-16-4/#:~:text=Outline%20%2B%20Border%20Radius

@cpmsmith
Copy link
Contributor Author

Hello! This should be updated to show just for versions below 16.4: https://webkit.org/blog/13966/webkit-features-in-safari-16-4/#:~:text=Outline%20%2B%20Border%20Radius

Good point—opened #20424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants