Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing LaunchQueue/LaunchParams API #17682

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Sep 4, 2022

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing LaunchParams and LaunchQueue APIs, populating the results using data from the mdn-bcd-collector project (v6.1.2).

Tests Used:
https://mdn-bcd-collector.appspot.com/tests/api/Window/launchQueue
https://mdn-bcd-collector.appspot.com/tests/api/LaunchParams
https://mdn-bcd-collector.appspot.com/tests/api/LaunchQueue

Check out the collector's guide on how to review this PR.

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser.  This particular PR adds the missing `LaunchParams` API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v6.1.2).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/LaunchParams

_Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser.  This particular PR adds the missing `LaunchQueue` API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v6.1.2).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/LaunchQueue

_Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 4, 2022
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the window.launchQueue property for this API. (and if that one doesn't work, then the whole API isn't accessible, I assume)

@queengooborg queengooborg changed the title Add missing LaunchQueue API Add missing LaunchQueue/LaunchParams API Sep 9, 2022
@Elchi3 Elchi3 merged commit 1a35682 into mdn:main Sep 12, 2022
@queengooborg queengooborg deleted the api/LaunchQueue branch September 12, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants