Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ScreenDetails API #17685

Merged
merged 2 commits into from
Sep 10, 2022
Merged

Add missing ScreenDetails API #17685

merged 2 commits into from
Sep 10, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Sep 4, 2022

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing ScreenDetails API, populating the results using data from the mdn-bcd-collector project (v6.1.2).

Tests Used:
https://mdn-bcd-collector.appspot.com/tests/api/ScreenDetails
https://mdn-bcd-collector.appspot.com/tests/api/Window/getScreenDetails

Check out the collector's guide on how to review this PR.

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser.  This particular PR adds the missing `ScreenDetails` API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v6.1.2).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/ScreenDetails

_Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 4, 2022
@foolip
Copy link
Collaborator

foolip commented Sep 4, 2022

Can you also add the getScreenDetails() entry point, confirming it's actually supported? It would have been best to this PR and #17684 together, but I merged that before realizing.

@foolip foolip merged commit 428cd2d into mdn:main Sep 10, 2022
@queengooborg queengooborg deleted the api/ScreenDetails branch September 10, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants