-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebMidi access is more than just secure context #18160
Conversation
"notes": [ | ||
"Version 107 and later, API use is gated by a site permission add-on that is automatically generated by Firefox.", | ||
"Version 105 and later, the <code>dom.webmidi.gated</code> preference may be set <code>false</code> to allow WebMIDI to be used without a site permission addon.", | ||
"Version 100 to 104 (inclusive) WebMIDI is not available (API use is gated by a site permission add-on that is no longer available)." | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preference version includes all the data. I am expecting this to be deleted when the feature goes live.
@@ -3744,7 +3744,8 @@ | |||
"edge": "mirror", | |||
"firefox": [ | |||
{ | |||
"version_added": "preview" | |||
"version_added": "preview", | |||
"notes": "API access is gated by installation of a site permission add-on (user prompt), secure context, and <a href='https://developer.mozilla.org/docs/Web/HTTP/Headers/Feature-Policy/midi'>Permission Policy: <code>midi</code></a>." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview version contains specific information about the site permission add on and feature policy gating.
We will need to link to docs on the site permission when Firefox has written them.
This pull request has merge conflicts that must be resolved before it can be merged. |
Merges changes from mdn#18160
Closing - merging changes into #18213 |
#18115 added information about the firefox site permission updates to the secure context docs, replacing an out of date note.
On reflection though secure context is mostly about requiring HTTPS - and the site permission behaviour is about user prompting.
So what I have done is moved the notes out of secure context and as a note against the API itself.
@queengooborg FYI