Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete API features #18258

Merged
merged 5 commits into from
Dec 30, 2022
Merged

Remove obsolete API features #18258

merged 5 commits into from
Dec 30, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR removes all of the features that are marked obsolete by #17743 for the API folder. All of the features were confirmed to be considered irrelevant or unsupported as validated by the mdn-bcd-collector project.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 22, 2022
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Nov 22, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg mentioned this pull request Dec 10, 2022
Merged
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Dec 11, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Elchi3
Elchi3 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we can remove one WebRTC file that looks like a dictionary to me and for a few things MDN content needs to be removed still.

api/Document.json Show resolved Hide resolved
api/Element.json Show resolved Hide resolved
api/HTMLCanvasElement.json Show resolved Hide resolved
api/RTCIceCredentialType.json Outdated Show resolved Hide resolved
@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Dec 21, 2022
@queengooborg queengooborg mentioned this pull request Dec 29, 2022
Merged
@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Dec 29, 2022
@Elchi3
Copy link
Member

Elchi3 commented Dec 29, 2022

Conflict needs to be resolved then this is ready to land. Thank you!

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@Elchi3 Elchi3 merged commit bdd23cd into mdn:main Dec 30, 2022
@queengooborg queengooborg deleted the api/remove-obsolete branch December 30, 2022 10:56
@BitcoinOutput BitcoinOutput mentioned this pull request Apr 6, 2024
Open
@adamlaska adamlaska mentioned this pull request Apr 6, 2024
Open
@Aknc34 Aknc34 mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@queengooborg @Elchi3