Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "logical nullish assignment" to "nullish coalescing assignment" #18700

Merged
merged 1 commit into from Jan 23, 2023
Merged

Rename "logical nullish assignment" to "nullish coalescing assignment" #18700

merged 1 commit into from Jan 23, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR fixes the name for the logical nullish assignment operator and changes it to the nullish coalescing assignment operator following the content change. Fixes #18558.

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jan 20, 2023
Elchi3
Elchi3 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but blocked on content update.

@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jan 23, 2023
@queengooborg queengooborg mentioned this pull request Jan 23, 2023
Merged
@queengooborg
Copy link
Collaborator Author

Content update complete so merging.

@queengooborg queengooborg merged commit bb9cb96 into mdn:main Jan 23, 2023
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jan 23, 2023
@queengooborg queengooborg deleted the javascript/operators/nullish branch January 28, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

javascript.operators.logical_nullish_assignment - The name doesn't reflect the change of the operator's name
2 participants
@queengooborg @Elchi3