Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Custom Highlight API follow-ups #18720

Merged
merged 4 commits into from
Jan 30, 2023
Merged

CSS Custom Highlight API follow-ups #18720

merged 4 commits into from
Jan 30, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Jan 23, 2023 •
edited

Summary

  • Marked API as non-experimental: the API shipped on-by-default in Chromium-based browsers. I don't believe we're in the experimental phase anymore where browsers are waiting for feedback (although the API is still off-by-default in Safari).
  • Added the missing ::highlight() pseudo-element, which comes with this API.
  • Changed the spec URLs to use the www.w3.org server instead.

@captainbrosset
CSS Custom Highlight API follow-ups
6a81ddc 
Marked API as non-experimental.
Added the missing ::highlight() pseudo-element.
@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Jan 23, 2023
@captainbrosset captainbrosset mentioned this pull request Jan 26, 2023
Merged
@Elchi3
Copy link
Member

Elchi3 commented Jan 27, 2023

Thanks for your PR! Some comments:

  • Marked API as non-experimental: the API shipped on-by-default in Chromium-based browsers. I don't believe we're in the experimental phase anymore where browsers are waiting for feedback (although the API is still off-by-default in Safari).

I think this is against the guideline (https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#setting-experimental). We need two engines that ship enabled by default.

  • Added the missing ::highlight() pseudo-element, which comes with this API.

👍

  • Changed the spec URLs to use the www.w3.org server instead.

Usually we try to link to the latest Editor's Draft to not risk to refer to outdated specs.

@captainbrosset
Copy link
Contributor Author

@Elchi3 thanks! The last commit should address your comments.

Elchi3
Elchi3 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit f8f48f5 into mdn:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@captainbrosset @Elchi3