Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for Element.animate() options.timeline #18776

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

ninevra
Copy link
Contributor

@ninevra ninevra commented Jan 29, 2023

Summary

Adds support data for the timeline property of the options parameter of Element.animate().

Firefox does not support this option. Chromium does, likely since version 85. Safari likely does, since version 16.

Test results and supporting details

Manually tested in Firefox 111 and Chromium 109. A simple test case is:

console.assert(
  document.body.animate([], { timeline: new DocumentTimeline() }).timeline !== document.timeline
);

Chromium support was added in d393163, which released in Chromium 85.

Safari support was added in WebKit/WebKit@1a2775d, included in WebKit since 614.1.6, which is Safari 16.

I don't have a setup to test Safari 16 or any additional browsers at the moment; the "mirror" entries are pure speculation, since the linter disallows null. I apologize if that makes this PR not useful.

Checked Firefox, Chromium support, researched Safari, Chromium support.
Mirrors are pure speculation.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 29, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Elchi3 Elchi3 merged commit 0649c1e into mdn:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants